Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support method to output lines only to version0,1,3 or version4 #102

Merged
merged 2 commits into from Feb 4, 2018

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Feb 3, 2018

I consider this strategy temporary until version 0,1,3 is finalized by
IETF.

@dericed
Copy link
Contributor Author

dericed commented Feb 3, 2018

This PR is intended to supersede #93.

@michaelni
Copy link
Member

breaks build:

pandoc --toc -s --number-sections --pdf-engine=pdflatex -V geometry:margin=1in --variable urlcolor=blue -o "ffv1.pdf" merged_ffv1pdf.md
pandoc: unrecognized option `--pdf-engine=pdflatex'
Try pandoc --help for more information.
make: *** [ffv1.pdf] Error 2

@michaelni
Copy link
Member

pandoc --version
pandoc 1.19
Compiled with pandoc-types 1.17.0.4, texmath 0.9, highlighting-kate 0.6.3
Default user data directory: /home/michael/.pandoc
Copyright (C) 2006-2016 John MacFarlane

I consider this strategy temporary until version 0,1,3 is finalized by
IETF.
@dericed
Copy link
Contributor Author

dericed commented Feb 4, 2018

Hi @michaelni, for me I had to change --latex-engine=xelatex to --pdf-engine=pdflatex else I would get

--latex-engine has been removed.  Use --pdf-engine instead.
Try pandoc --help for more information.

but I'm on pandoc 2.1.1. I changed it back so as not to conflate the issues in a single PR, but I suggest we consider updating the pandoc dependency to a more modern version.

The PR is updated for pandoc 1.19 for a re-review.

@dericed
Copy link
Contributor Author

dericed commented Feb 4, 2018

I added one more commit to split the title and use "FFV1 Lossless Video Format Version 0, 1, and 3" and "FFV1 Lossless Video Format Version 4" rather than "FF Video Codec 1". IMHO "FF Video Codec 1" is an unfamiliar term and using FFV1 in the title would be better.

@JeromeMartinez
Copy link
Contributor

I suggest  "FFV1 Video Coding Format Version (...)", like in https://en.wikipedia.org/wiki/AV1

@dericed
Copy link
Contributor Author

dericed commented Feb 4, 2018

@JeromeMartinez i agree, updated

@michaelni michaelni merged commit ab99984 into FFmpeg:master Feb 4, 2018
@dericed dericed deleted the split-ffv1-version-outputs branch May 28, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants